Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small consistency improvements #536

Merged
merged 4 commits into from
Mar 6, 2024
Merged

docs: small consistency improvements #536

merged 4 commits into from
Mar 6, 2024

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Mar 5, 2024

Proposed Changes

  • docs: backticks everywhere
  • chore: ignore .idea directory
  • docs: consistently use returns over return

@wochinge wochinge marked this pull request as ready for review March 5, 2024 16:46
@wochinge wochinge requested a review from a team as a code owner March 5, 2024 16:46
@wochinge wochinge requested review from vblagoje and removed request for a team March 5, 2024 16:46
@wochinge wochinge requested a review from shadeMe March 6, 2024 08:28
@anakin87 anakin87 self-requested a review March 6, 2024 08:29
anakin87
anakin87 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@wochinge wochinge merged commit 0676fb4 into main Mar 6, 2024
66 checks passed
@wochinge wochinge deleted the docs/small-consistency-improvements branch March 6, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anakin87 anakin87 anakin87 approved these changes

@vblagoje vblagoje Awaiting requested review from vblagoje vblagoje is a code owner automatically assigned from deepset-ai/open-source-engineering

@shadeMe shadeMe Awaiting requested review from shadeMe

Assignees

@shadeMe shadeMe

Labels
integration:amazon-bedrock integration:amazon-sagemaker integration:astra integration:chroma integration:cohere integration:fastembed integration:google-vertex integration:llama_cpp integration:mongodb-atlas integration:opensearch integration:qdrant integration:unstructured-fileconverter topic:DX type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wochinge @anakin87 @shadeMe