Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix Optimum embedder examples #517

Merged
merged 2 commits into from
Mar 1, 2024
Merged

docs: Fix Optimum embedder examples #517

merged 2 commits into from
Mar 1, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Mar 1, 2024 •
edited
Loading

No description provided.

@github-actions github-actions bot added integration:optimum type:documentation Improvements or additions to documentation labels Mar 1, 2024
@shadeMe shadeMe changed the title fix: Fix Optimum text preprocessing for the document embedder docs: Fix Optimum embedder examples Mar 1, 2024
@shadeMe shadeMe marked this pull request as ready for review March 1, 2024 16:59
@shadeMe shadeMe requested a review from a team as a code owner March 1, 2024 16:59
@shadeMe shadeMe requested review from julian-risch and removed request for a team March 1, 2024 16:59
julian-risch
julian-risch approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@shadeMe shadeMe merged commit b347b30 into deepset-ai:main Mar 1, 2024
10 checks passed
@shadeMe shadeMe deleted the fix/optimum-doc-embed branch March 1, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
integration:optimum type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadeMe @julian-risch