Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Simplify Optimum backend impl #477

Merged
merged 1 commit into from
Feb 23, 2024
Merged

refactor!: Simplify Optimum backend impl #477

merged 1 commit into from
Feb 23, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Feb 23, 2024

In preparation for the optimizer/quantizer integration.

@github-actions github-actions bot added integration:optimum type:documentation Improvements or additions to documentation labels Feb 23, 2024
@shadeMe shadeMe force-pushed the refactor/optimum-simplify-impl branch from 2db33b5 to e0e6840 Compare February 23, 2024 13:12
@shadeMe shadeMe marked this pull request as ready for review February 23, 2024 13:19
@shadeMe shadeMe requested a review from a team as a code owner February 23, 2024 13:19
@shadeMe shadeMe requested review from masci and removed request for a team February 23, 2024 13:19
masci
masci approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the diff and it mostly looks like rearranging code, so LGTM. Let me know if that's a wrong assumption and I should pay attention to any particular area instead.

@shadeMe
Copy link
Contributor Author

shadeMe commented Feb 23, 2024

I went through the diff and it mostly looks like rearranging code, so LGTM. Let me know if that's a wrong assumption and I should pay attention to any particular area instead.

That's correct - It's just regular refactoring.

@shadeMe shadeMe merged commit 7a8a292 into main Feb 23, 2024
10 checks passed
@shadeMe shadeMe deleted the refactor/optimum-simplify-impl branch February 23, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
integration:optimum type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shadeMe @masci