fix: Revert "Allow passing in required project_name (#445)" #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ffe86a9.
github-actions
bot
added
integration:uptrain
type:documentation
…ator doc: Update docstring to mention required API parameters
shadeMe
force-pushed
the
fix/revert-project-name-param
branch
from
9045f75
to
d65bd6c
Compare
shadeMe
requested review from
silvanocerza and
masci
and removed request for
a team
shadeMe
changed the title
masci
approved these changes
Feb 22, 2024
|
Thanks for the fix 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ffe86a9 as it adds a superfluous parameter - API-specific params like
project_namecan be already be passed with theapi_paramsinit parameter.This PR additionally clarifies this in the component's docstring and adds a sanity check to make sure the required API params are correctly passed.