Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Use Secret for API key in UpTrainEvaluator #347

Merged
merged 3 commits into from
Feb 7, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Feb 6, 2024

And some other misc build fixes.

@shadeMe shadeMe marked this pull request as ready for review February 6, 2024 16:00
@shadeMe shadeMe requested a review from a team as a code owner February 6, 2024 16:00
@shadeMe shadeMe requested review from anakin87 and removed request for a team February 6, 2024 16:00
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, it looks good.
I only left a comment.

@shadeMe shadeMe requested a review from anakin87 February 7, 2024 09:07
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Feb 7, 2024
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change integration:uptrain type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants