Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Rename model_name to model in AmazonBedrockGenerator #220

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Jan 16, 2024

Related Issues

Proposed Changes:

  • Rename model_name or model_name_or_path to model in AmazonBedrockGenerator and related classes/methods.

How did you test it?

Local tests run, CI

@ZanSara ZanSara marked this pull request as ready for review January 16, 2024 16:12
@ZanSara ZanSara requested a review from a team as a code owner January 16, 2024 16:12
@ZanSara ZanSara requested review from anakin87 and removed request for a team January 16, 2024 16:12
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants