Prometheus 2 notebook #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
TuanaCelik
reviewed
Jun 6, 2024
| @@ -0,0 +1,12348 @@ | |||
| { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
yes. Now I have clarified it a bit.
TuanaCelik
approved these changes
Jun 10, 2024
| @@ -0,0 +1,12347 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe this can be removed or commented and with a comment added that if the user ran the RAG pipeline no need for this step
Reply via ReviewNB
There was a problem hiding this comment.
Makes sense. I will clarify this point.
| @@ -0,0 +1,12347 @@ | |||
| { | |||
There was a problem hiding this comment.
nit: a newest release will already show the column metrics, and not that columns as the index in the dataframe
Reply via ReviewNB
There was a problem hiding this comment.
OK for now let's leave it as is.
davidsbatista
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this notebook, I'm experimenting with Prometheus 2 to evaluate RAG pipelines.
@TuanaCelik take a look and see how we could communicate this
@bilgeyucel (optional): take a look, see if it is understandable