Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notebook: prompt optimization with DSPy #86

Merged
merged 4 commits into from
Jun 4, 2024
Merged

notebook: prompt optimization with DSPy #86

merged 4 commits into from
Jun 4, 2024

Conversation

anakin87
Copy link
Member

In this notebook, I show how to optimize the prompt to get correct and short answers.

I need you to review the notebook, referring to two main aspects.

  • Comprehensibility: it may be difficult to fully understand the logic for those unfamiliar with DSPy,
  • Messaging: it should be clear that DSPy can be used for the prompt optimization part and has a different scope than Haystack. Related DSPy FAQ.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@anakin87 anakin87 requested review from a team and mrm1001 May 28, 2024 10:21
@mrm1001
Copy link
Member

mrm1001 commented May 28, 2024

Nothing to add, I think this is great! well done! 👏

@anakin87 anakin87 requested a review from TuanaCelik June 4, 2024 07:53
TuanaCelik
TuanaCelik approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@TuanaCelik TuanaCelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@anakin87 anakin87 merged commit d8b64ad into main Jun 4, 2024
@anakin87 anakin87 deleted the prompt-optimization-dspy branch June 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuanaCelik TuanaCelik TuanaCelik approved these changes

@mrm1001 mrm1001 Awaiting requested review from mrm1001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anakin87 @mrm1001 @TuanaCelik