Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extracting_metadata_filters_from_a_user_query.ipynb cookbook #82

Merged
merged 5 commits into from
May 10, 2024

Conversation

bilgeyucel
Copy link
Contributor

No description provided.

@bilgeyucel bilgeyucel self-assigned this May 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,878 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #47.            # this can be done with specific data structures and in a more sophisticated way

although this makes sense, we can maybe remove it since it's a cookbook - I don't know, you can decide :)


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to leave as it provides a nice improvement point :)

Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a simple comment

@bilgeyucel bilgeyucel merged commit ffbd5e1 into deepset-ai:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants