Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create session api #6

Merged
merged 6 commits into from
May 11, 2023
Merged

feat: create session api #6

merged 6 commits into from
May 11, 2023

Conversation

ArzelaAscoIi
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi commented May 10, 2023

Related Issues

  • utilities for creating sessions

Proposed Changes?

  • create session
  • close session
  • list session
  • get session status

How did you test it?

  • unit tests
  • integration tests

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@github-actions
Copy link

github-actions bot commented May 11, 2023

Coverage report

The coverage rate went from 100% to 100% ➡️
The branch rate is 100%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

deepset_cloud_sdk/api/upload_sessions.py

100% of new lines are covered (100% of the complete file).

deepset_cloud_sdk/models.py

100% of new lines are covered (100% of the complete file).

@ArzelaAscoIi ArzelaAscoIi requested a review from rjanjua May 11, 2023 08:57
Copy link
Collaborator

@rjanjua rjanjua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Getting through the endpoints like a 🚀

Nice test coverage ✅

@ArzelaAscoIi ArzelaAscoIi merged commit dee00fa into main May 11, 2023
@ArzelaAscoIi ArzelaAscoIi deleted the feat/uploadSessionApi branch May 11, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants