Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: move dependencies to right place #17

Merged
merged 4 commits into from
May 12, 2023
Merged

build: move dependencies to right place #17

merged 4 commits into from
May 12, 2023

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented May 12, 2023 •
edited
Loading

Related Issues

  • fixes #issue-number

Proposed Changes?

  • build: move dependencies to correct env

How did you test it?

Notes for the reviewer

Screenshots (optional)

Checklist

  • I have updated the referenced issue with new insights and changes
  • If this is a code change, I have added unit tests
  • I've used the conventional commit specification for my PR title
  • I updated the docstrings
  • If this is a code change, I added meaningful logs and prepared Datadog visualizations and alerts

@wochinge wochinge force-pushed the ci/fossa-experiment branch 3 times, most recently from db3a429 to b9bf9e1 Compare May 12, 2023 13:03
@wochinge wochinge changed the title ci/fossa experiment build: move dependencies to right place May 12, 2023
@wochinge wochinge marked this pull request as ready for review May 12, 2023 13:12
ArzelaAscoIi
ArzelaAscoIi approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@ArzelaAscoIi ArzelaAscoIi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 amazing. I was already confused by this but wasnt sure about how hatch uses it 🙈

@wochinge wochinge merged commit c98b39f into main May 12, 2023
@wochinge wochinge deleted the ci/fossa-experiment branch May 12, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArzelaAscoIi ArzelaAscoIi ArzelaAscoIi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wochinge @ArzelaAscoIi