Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model_id in response #90

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Add model_id in response #90

merged 1 commit into from
Mar 27, 2020

Conversation

tanaysoni
Copy link
Contributor

With the new unified QA endpoint, the model_id to use is no longer explicit in the request. However, the model_id is needed for the feedback endpoint.

This PR adds model_id in the response body.

@tanaysoni tanaysoni requested a review from tholor March 27, 2020 10:47
@tanaysoni tanaysoni merged commit 007bc0b into master Mar 27, 2020
@tanaysoni tanaysoni deleted the add-model-id-in-resp branch March 27, 2020 11:58
@tanaysoni tanaysoni mentioned this pull request Mar 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanaysoni @tholor