Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add init-reaction docs and args #758

Merged
merged 5 commits into from
Jul 5, 2022
Merged

add init-reaction docs and args #758

merged 5 commits into from
Jul 5, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Jun 20, 2022

The commit includes:

  • add docs
  • add detailed arguments
  • add strict argument checking
  • strict check the init-reaction example

@njzjz
add init-reaction docs and args
4fee87c 
The commit includes:
- add docs
- add detailed arguments
- add strict argument checking
- strict check the init-reaction example
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022 •
edited
Loading

Codecov Report

Merging #758 (8d9365a) into devel (bace57e) will increase coverage by 0.12%.
The diff coverage is 84.61%.

@@            Coverage Diff             @@
##            devel     #758      +/-   ##
==========================================
+ Coverage   34.81%   34.94%   +0.12%     
==========================================
  Files          96       96              
  Lines       16633    16657      +24     
==========================================
+ Hits         5790     5820      +30     
+ Misses      10843    10837       -6
Impacted Files Coverage Δ
dpgen/data/reaction.py 0.00% <0.00%> (ø)
dpgen/data/arginfo.py 87.50% <100.00%> (+87.50%) ⬆️
dpgen/util.py 90.90% <100.00%> (+2.67%) ⬆️
dpgen/arginfo.py 33.33% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bace57e...8d9365a. Read the comment docs.

@njzjz
Copy link
Member Author

njzjz commented Jun 20, 2022

Preview of docs are available at:

@njzjz njzjz added the documentation Improvements or additions to documentation label Jun 20, 2022
@AnguseZhang AnguseZhang merged commit 48f2abe into deepmodeling:devel Jul 5, 2022
@njzjz njzjz mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnguseZhang AnguseZhang AnguseZhang approved these changes

@wanghan-iapcm wanghan-iapcm wanghan-iapcm approved these changes

@HuangJiameng HuangJiameng HuangJiameng approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
No open projects
Add docs for DP-GEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@njzjz @codecov-commenter @AnguseZhang @wanghan-iapcm @HuangJiameng