Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bcc interstitial calculation and change some default parameters in lmp #696

Merged
merged 9 commits into from
Apr 13, 2022

Conversation

kevinwenminion
Copy link
Collaborator

  1. Add bcc interstitial calculations for transition metals which have six types of interstitial positions.
  2. In lmp relaxation, change the convergence to be controlled by the force criteria. This is more reasonable, especially for large systems.
  3. Change the "pair_coeff" in lmp to be compatible with the latest lmp version.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #696 (fc531a8) into devel (9e3b958) will decrease coverage by 0.20%.
The diff coverage is 4.42%.

@@            Coverage Diff             @@
##            devel     #696      +/-   ##
==========================================
- Coverage   33.94%   33.73%   -0.21%     
==========================================
  Files          86       86              
  Lines       15424    15525     +101     
==========================================
+ Hits         5235     5237       +2     
- Misses      10189    10288      +99     
Impacted Files Coverage Δ
dpgen/auto_test/Interstitial.py 6.71% <0.00%> (-3.56%) ⬇️
dpgen/auto_test/common_equi.py 61.59% <30.00%> (+0.11%) ⬆️
dpgen/auto_test/lib/lammps.py 27.12% <40.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3b958...fc531a8. Read the comment docs.

Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a UT for added the BCC interstitial?

@kevinwenminion
Copy link
Collaborator Author

Could you please add a UT for added the BCC interstitial?

Yes, I will add the unittest.

@kevinwenminion
Copy link
Collaborator Author

BCC interstitial unittest has been added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants