Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite data doc #1668

Merged
merged 3 commits into from
Apr 29, 2022
Merged

rewrite data doc #1668

merged 3 commits into from
Apr 29, 2022

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Apr 28, 2022

Current data doc was wrttien in the inital version. It's out-of-date.

Current data doc was wrttien in the inital version. It's out-of-date.
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #1668 (9eccb46) into devel (2bf51f3) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #1668      +/-   ##
==========================================
+ Coverage   76.15%   76.24%   +0.09%     
==========================================
  Files          94       94              
  Lines        7850     7842       -8     
==========================================
+ Hits         5978     5979       +1     
+ Misses       1872     1863       -9     
Impacted Files Coverage Δ
deepmd/entrypoints/compress.py 73.77% <0.00%> (+0.43%) ⬆️
deepmd/calculator.py 80.00% <0.00%> (+0.58%) ⬆️
deepmd/utils/tabulate.py 84.31% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf51f3...9eccb46. Read the comment docs.


A system should contain system properties, input frame properties, and labeled frame properties. The system property contains the following property:

ID | Property | Required/Optional | Shape | Description
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also provide the name of the raw file?

Copy link
Collaborator

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also provide the raw file name for the frame properties and labels? I would recommend we do so.

@wanghan-iapcm wanghan-iapcm merged commit a31544c into deepmodeling:devel Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants