Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple plots in same operation (Closes #1975) #1976

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

umesh-timalsina
Copy link
Contributor

@umesh-timalsina umesh-timalsina commented Nov 11, 2020

Still needs some digging but I found that the following find function's

const node = metadata.find(node => this.core.getAttribute(node, 'id')) ||
await this.createNodeForMetadata(MetadataClass, job, id);

condition is always truthy. This will thus override any other graphs that were created.

@brollb
Copy link
Contributor

brollb commented Nov 11, 2020

Good catch! Thanks

@brollb brollb merged commit cead1ec into master Nov 11, 2020
@brollb brollb deleted the 1975-multi-plot-support branch November 11, 2020 14:45
@brollb brollb restored the 1975-multi-plot-support branch November 11, 2020 14:48
brollb added a commit that referenced this pull request Nov 11, 2020
@brollb brollb deleted the 1975-multi-plot-support branch November 11, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants