Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code editor type inference #571

Open
brollb opened this issue Jul 29, 2016 · 4 comments
Open

code editor type inference #571

brollb opened this issue Jul 29, 2016 · 4 comments

Comments

@brollb
Copy link
Contributor

brollb commented Jul 29, 2016

To support more robust autocomplete in the code editors, we should use type inference before determining the possible completions

@brollb
Copy link
Contributor Author

brollb commented Jul 23, 2018

This could be achieved by integrating python language server support.

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Jun 7, 2020

I have been looking into https://github.com/microsoft/monaco-editor. This editor is a shimmed editor from VSCode sources and runs on browsers (no mobile device support), has some documentation and examples and provides support for syntax highlighting for the languages we use. Instead of writing a completer logic for ace we could develop a monaco text editor (should not be that difficult to do as a lot of out of box defaults would work for our case) See (microsoft/monaco-editor#19).

A languge server client for Monaco editor has been developed here.

@brollb
Copy link
Contributor Author

brollb commented Jun 24, 2020

Another related project: https://github.com/eclipse-theia/theia

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Sep 16, 2020

This issue needs to be broken down into two different issues.

  1. Integrate Monaco TextEditor. (This issue)
  2. Integrate a python language server with MonacoTextEditor

brollb added a commit that referenced this issue Sep 17, 2020
* Initial commit for replacing ace with monaco editor

* WIP- Remove ace from TextEditor

* WIP- Integrate vim keybindings

* Ensure editor hasn't been destroyed while loading vim keybindings

* Remove dummy python code for ''

* WIP- Add support for additional themes

* WIP- Fix eslint issues, remove unused functions in LogViewerWidget

* WIP- Fix more eslint and code climate fixes

* WIP- Fix model dispose problem by disposing editor only

* WIP-Remove console.log statement from TextEditorWidget.js

Co-authored-by: Brian Broll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants