Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all pipeline figures from execution index #1907

Closed
brollb opened this issue Sep 16, 2020 · 5 comments
Closed

Show all pipeline figures from execution index #1907

brollb opened this issue Sep 16, 2020 · 5 comments
Assignees
Labels
enhancement job feedback Graphs, images, and other feedback generated during job execution. ui/ux

Comments

@brollb
Copy link
Contributor

brollb commented Sep 16, 2020

Since we aren't combining plots anymore from the execution index, it might be nice to show all figures from the selected executions.

@brollb brollb added enhancement ui/ux job feedback Graphs, images, and other feedback generated during job execution. labels Sep 16, 2020
@umesh-timalsina
Copy link
Contributor

Don't we already do that? I.e. use the widget to show multiple plotly plots.

@brollb
Copy link
Contributor Author

brollb commented Sep 16, 2020

I thought so but is that the case when there are multiple plots generated by a single execution? I was reviewing #1896 and @KyleAMoore mentioned that only one plot per execution is shown.

@brollb
Copy link
Contributor Author

brollb commented Sep 16, 2020

Then we can remove things like "Unfortunately, only one of the two figures can be viewed from this page. " from the docs :)

@KyleAMoore
Copy link
Contributor

Unless I am missing something, it is correct that pipeline executions which generate multiple figures will only display one of those figures. See the screenshot linked for example. The selected execution generates two plots, one from each of the last two operations. Only one is being displayed, and I cannot find a control that will switch between the two plots or shows them together.

As far as I can tell, the only way right now to view the second plot that is generated is to open the console output for the unshown figure and select the graph view. In #1896, I use this as an opportunity to introduce this feature, so it is convenient for documentation purposes, but it may be preferable to allow switching from the executions tab for user friendliness.

image

@umesh-timalsina
Copy link
Contributor

umesh-timalsina commented Sep 16, 2020

@KyleAMoore, you are right only one figure is grabbed for an execution currently, we can support this feature, but not sure if we wanted to use something like #1766 (comment) or extend the existing visualizer area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement job feedback Graphs, images, and other feedback generated during job execution. ui/ux
Projects
None yet
Development

No branches or pull requests

3 participants