Skip to content

Commit

Permalink
[FLINK-18120] Don't expand documentation sections by default
Browse files Browse the repository at this point in the history
This is basically a revert of FLINK-16041. The idea seemed good at the
time but with more sections being added this just looks too unwieldy
when you first open the docs
  • Loading branch information
aljoscha committed Jun 4, 2020
1 parent 05332b5 commit 20abff9
Show file tree
Hide file tree
Showing 9 changed files with 1 addition and 11 deletions.
4 changes: 1 addition & 3 deletions docs/_includes/sidenav.html
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,6 @@
{%- assign active = true -%}
{%- elsif this.nav-id and active_nav_ids contains this.nav-id -%}
{%- assign active = true -%}
{%- elsif this.always-expand -%}
{%- assign active = true -%}
{%- else -%}
{%- assign active = false -%}
{%- endif -%}
Expand All @@ -119,7 +117,7 @@
{%- if children.size > 0 -%}
{%- assign children = (children[0].items | sort: "nav-pos") -%}
{%- capture collapse_target -%}"#collapse-{{ i }}" data-toggle="collapse"{%- if active -%} class="active"{%- endif -%}{%- endcapture -%}
{%- capture expand -%}<i class="fa fa-caret-down pull-right" aria-hidden="true" style="padding-top: 4px"></i>{%- endcapture %}
{%- capture expand -%}{%- unless active -%} <i class="fa fa-caret-down pull-right" aria-hidden="true" style="padding-top: 4px"></i>{%- endunless -%}{%- endcapture %}
<li><a href={{ collapse_target }}>{{ title }}{{ expand }}</a><div class="collapse{% if active %} in{% endif %}" id="collapse-{{ i }}"><ul>
{%- if this.nav-show_overview %}
<li><a href={{ overview_target }}>
Expand Down
1 change: 0 additions & 1 deletion docs/concepts/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ nav-title: '<i class="fa fa-map-o title appetizer" aria-hidden="true"></i> Conce
nav-parent_id: root
nav-show_overview: true
permalink: /concepts/index.html
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/concepts/index.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ nav-title: '<i class="fa fa-map-o title appetizer" aria-hidden="true"></i> 概
nav-parent_id: root
nav-show_overview: true
permalink: /concepts/index.html
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/dev/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ nav-title: '<i class="fa fa-code title maindish" aria-hidden="true"></i> Applica
nav-parent_id: root
nav-pos: 5
section-break: true
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/dev/index.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ nav-title: '<i class="fa fa-code title maindish" aria-hidden="true"></i> 应用
nav-parent_id: root
nav-pos: 5
section-break: true
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/getting-started/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ nav-parent_id: root
section-break: true
nav-show_overview: true
nav-pos: 1
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/getting-started/index.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ nav-parent_id: root
section-break: true
nav-show_overview: true
nav-pos: 1
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/training/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ nav-pos: 2
nav-title: '<i class="fa fa-hand-paper-o title appetizer" aria-hidden="true"></i> Hands-on Training'
nav-parent_id: root
nav-show_overview: true
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down
1 change: 0 additions & 1 deletion docs/training/index.zh.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ nav-pos: 2
nav-title: '<i class="fa fa-hand-paper-o title appetizer" aria-hidden="true"></i> Hands-on Training'
nav-parent_id: root
nav-show_overview: true
always-expand: true
---
<!--
Licensed to the Apache Software Foundation (ASF) under one
Expand Down

0 comments on commit 20abff9

Please sign in to comment.