ticketvote: Cast vote error format. #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the `ErrorCode` field in the `CastVoteReply` structs to a pointer, in order to fix a bug where default error code value `ErrorCodeInvalid` was returned on success which is not correct. After this, in case of success the error code pointer will be nil.
lukebp
requested changes
Oct 29, 2021
lukebp
reviewed
Oct 29, 2021
lukebp
approved these changes
Oct 29, 2021
marcopeereboom
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the
ErrorCodefield in theCastVoteReplystructsto a pointer, in order to fix a bug where default error code value
ErrorCodeInvalidwas returned on success.After this, in case of success the error code pointer will be nil.
Closes #1557.