multi: Move identity methods. #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves two identity methods out of the `util` package and in into more appropriate places. `IdentityFromString` was moved into the `identity` package with the other identity methods and was renamed to `PublicIdentityFromString` in order to be consistent with the existing naming convetion. `RemoteIdentity` was moved into `politeiawww/identity.go` since this is the only place in the codebase that it was being invoked. It was renamed to `remoteIdentity`.
marcopeereboom
approved these changes
Oct 11, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff moves two identity methods out of the
utilpackage and ininto more appropriate places.
IdentityFromStringwas moved into theidentitypackage with theother identity methods and was renamed to
PublicIdentityFromStringinorder to be consistent with the existing naming convetion.
RemoteIdentitywas moved intopoliteiawww/identity.gosince this isthe only place in the codebase that it was being invoked. It was renamed
to
remoteIdentity.