Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tstorebe: Add record inventory fsck. #1520

Merged
merged 5 commits into from
Sep 30, 2021
Merged

Conversation

thi4go
Copy link
Member

@thi4go thi4go commented Sep 23, 2021

This diff adds a cache rebuild for the record inventory with the
filesystem check command --fsck.

Part of #1511

@thi4go
Copy link
Member Author

thi4go commented Sep 23, 2021

This is ready for a review @lukebp

@lukebp
Copy link
Member

lukebp commented Sep 23, 2021

@amass01 can you give this a review?

Copy link
Member

@amass01 amass01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK except of couple of minors

politeiad/backendv2/tstorebe/tstore/tstore.go Outdated Show resolved Hide resolved
politeiad/backendv2/tstorebe/tstorebe.go Outdated Show resolved Hide resolved
@amass01
Copy link
Member

amass01 commented Sep 23, 2021

Commit message should adhere the 72 cols requirement, see:
https://gist.github.com/lukebp/5a034ba73646903669719b4724a1d945#commit-messages

@lukebp
Copy link
Member

lukebp commented Sep 23, 2021

Link to the issue, not the original fsck PR. Also, your commit message title prefix should be the package the work is being performed in (tstorebe). Make sure your title line length adheres to the 50 column limit and you commit message body line length adheres to the 72 column limit.

@thi4go thi4go changed the title fsck: Add record inventory filesystem check. politeiad: Add record inventory fsck. Sep 24, 2021
@thi4go thi4go changed the title politeiad: Add record inventory fsck. tstorebe: Add record inventory fsck. Sep 24, 2021
@thi4go
Copy link
Member Author

thi4go commented Sep 24, 2021

Thx for the review mates @amass01 @lukebp comments addressed 👍

politeiad/backendv2/tstorebe/tstorebe.go Outdated Show resolved Hide resolved
politeiad/backendv2/tstorebe/tstorebe.go Outdated Show resolved Hide resolved
politeiad/backendv2/tstorebe/tstorebe.go Outdated Show resolved Hide resolved
politeiad/backendv2/tstorebe/tstorebe.go Outdated Show resolved Hide resolved
@thi4go
Copy link
Member Author

thi4go commented Sep 25, 2021

Round of comments addressed @lukebp 👍

Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Everything appears to be working correctly.

politeiad/backendv2/tstorebe/tstorebe.go Show resolved Hide resolved
politeiad/backendv2/tstorebe/tstorebe.go Outdated Show resolved Hide resolved
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@lukebp lukebp merged commit d7911eb into decred:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants