client/eth: Tx history recipient bug #2868
Conversation
The recipient field was being populated with the "to" field of the eth transaction (which may be a contract address) instead of the recipient of a send transaction as in other assets.
client/asset/eth/eth.go
Outdated
| var recipient *string | ||
| if to := tx.To(); to != nil { | ||
| s := to.String() | ||
| recipient = &s | ||
| } |
There was a problem hiding this comment.
Is it worth doing something like ?
if recipient == nil {
if to := tx.To(); to != nil {
s := to.String()
recipient = &s
}
}There was a problem hiding this comment.
You don't think it'll be confusing to have the swap contract address / bond contract address there?
There was a problem hiding this comment.
For swaps, we should be specifying the recipient, no?
There was a problem hiding this comment.
Do you mean the counterparty's address?
There was a problem hiding this comment.
I think I'm not fully grasping the intent here. Where's the "bug" exactly?
There was a problem hiding this comment.
The recipient field was supposed to show the recipient of a "send". For tokens, this will show the token contract address instead of the address where the tokens were sent.
There was a problem hiding this comment.
I guess I don't see a problem with having the contract as the recipient field, especially if we're just leaving it blank otherwise. More data is better.
There was a problem hiding this comment.
OK I guess it can't hurt.
* client/eth: Tx history recipient bug The recipient field was being populated with the "to" field of the eth transaction (which may be a contract address) instead of the recipient of a send transaction as in other assets. * Show recipient for all tx types
The recipient field was being populated with the "to" field of the eth transaction (which may be a contract address) instead of the recipient of a send transaction as in other assets.