Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tag pages and adjust config #51

Merged
merged 2 commits into from
Mar 23, 2018
Merged

add tag pages and adjust config #51

merged 2 commits into from
Mar 23, 2018

Conversation

rdela
Copy link
Contributor

@rdela rdela commented Feb 28, 2018

closes #35

I built this and tested as much as I could but not sure if I can sign into CMS to make sure tag editing works. I tried to match my seemingly working config.

Also updated paths to pages in config.yml

@rdela
Copy link
Contributor Author

rdela commented Feb 28, 2018

@erquhart
Copy link
Contributor

erquhart commented Mar 2, 2018

Just looking at the CMS implementation and preview site, this seems to work great.

@rdela
Copy link
Contributor Author

rdela commented Mar 5, 2018

Added flavor and tasting tags to Jamaican Blue post to demonstrate tag pages with more than one post:
https://deploy-preview-51--gatsby-netlify-cms.netlify.com/tags/flavor/
https://deploy-preview-51--gatsby-netlify-cms.netlify.com/tags/tasting/

@AustinGreen
Copy link
Contributor

This looks good to me, thank you @rdela. @erquhart do you have any comments?

@erquhart
Copy link
Contributor

Not reviewing code on this one, but the functionality looks good in preview 👍

@AustinGreen AustinGreen merged commit 6b929b7 into decaporg:master Mar 23, 2018
@rdela rdela deleted the tag-pages branch March 24, 2018 02:25
@ekoeryanto
Copy link
Contributor

halo, why we don't create category, also?

csw1995 pushed a commit to csw1995/unused-blog that referenced this pull request Aug 14, 2019
add tag pages and adjust config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag pages
4 participants