Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #44: Add back graphql fields #45

Closed
wants to merge 4 commits into from
Closed

Conversation

AustinGreen
Copy link
Contributor

A bit of noise because I ran prettier. The changes to gatsby-node.js are the only relevant ones.

@AustinGreen AustinGreen mentioned this pull request Feb 26, 2018
@erquhart
Copy link
Contributor

Those graphql fields aren't in use, they should be removed.

Feedback on this issue from @KyleAMathews:

kylemathews - Today at 7:38 PM
@erquhart someone imported graphql into one of the pages 😱
oh man, yeah, graphql is being imported everywhere
that's super not needed
Gatsby should lint against that 😦
that adds a ton of extra JS code to components

@erquhart
Copy link
Contributor

Fixed in #46.

@KyleAMathews
Copy link
Contributor

Why did you add back the graphql fields? You're not using them.

@AustinGreen
Copy link
Contributor Author

AustinGreen commented Feb 27, 2018 via email

@AustinGreen AustinGreen deleted the gatsby-node branch February 28, 2018 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants