Fix for #4225 & various other tweaks #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're the man for this, thank you |
erquhart
reviewed
Feb 25, 2018
| plan | ||
| price | ||
| } | ||
| } |
There was a problem hiding this comment.
@KyleAMathews the changes above seem like they remove meaningful configuration, is there new Gatsby functionality that makes this unnecessary?
There was a problem hiding this comment.
None of the data being queried is actually used
|
@AustinGreen I'll rebase this when I'm back at my machine, planning to merge unless you have objections. I might split the bugfix into a separate pr from the rest and just merge that, leaving the style stuff for you to merge if you approve. |
|
The style stuff is fine with me as long as it stays consistent. You can
still split it into two PRs if you think it makes sense for maintainability
reasons.
On Sun, Feb 25, 2018 at 13:38 Shawn Erquhart ***@***.***> wrote:
@AustinGreen <https://github.com/austingreen> I'll rebase this when I'm
back at my machine, planning to merge unless you have objections. I might
split the bugfix into a separate pr from the rest and just merge that,
leaving the style stuff for you to merge if you approve.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE9aq7xMKUA52C6NBPSzifB3EBT58wxsks5tYaihgaJpZM4SSG6m>
.
--
Austin Green
Product Engineer
|
|
related decaporg/decap-cms#1138 |
erquhart
approved these changes
Feb 26, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is pretty noisy as I ran Prettier which I guess hasn't been run before or in a while.
This PR broke this starter gatsbyjs/gatsby#4225 as reported in gatsbyjs/gatsby#4227