Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug section to README for node-gyp errors. #1

Closed
wants to merge 3 commits into from

Conversation

Recidvst
Copy link

The build was failing with npm node-gyp errors. Fix is to ensure that correct Python and Visual C++ build tools are installed. Suggest adding to README or a debug file as fix not apparent.

The build was failing with npm node-gyp errors. Fix is to ensure that correct Python and Visual C++ build tools are installed. Suggest adding to README or a debug file as fix not apparent.
@AustinGreen
Copy link
Contributor

Thanks for the PR. I'll take a look this weekend. I should mention that I'm going to be doing heavy work the next couple weekends to make the project a business example website.

@Recidvst
Copy link
Author

Great, look forward to checking it out mate. Thanks for setting up this starter build,

@Furgas
Copy link

Furgas commented Oct 27, 2017

Nice timing. I've just hit this error. Thanks for hint on installing windows-build-tools via npm.

"test": "echo \"Error: no test specified\" && exit 1"
},
"devDependencies": {
"prettier": "^1.7.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for removing prettier as a dev dependency, and the format script?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm understanding correctly - the only code change should be to the readme right?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah apologies, I only meant to push the readme yeah!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I cherry-picked that commit and merged

AustinGreen pushed a commit that referenced this pull request May 5, 2018
ZoltanVeres pushed a commit that referenced this pull request Mar 18, 2019
[ImgBot] Optimize images
csw1995 pushed a commit to csw1995/unused-blog that referenced this pull request Aug 14, 2019
csw1995 pushed a commit to csw1995/unused-blog that referenced this pull request Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants