Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maximum recursions #66

Open
sebdraven opened this issue Jul 21, 2016 · 2 comments
Open

Maximum recursions #66

sebdraven opened this issue Jul 21, 2016 · 2 comments
Assignees
@decalage2
Labels
🐛 bug major olefile
Milestone
Future Releases

Comments

@sebdraven
Copy link
Contributor

I make tests with http:https://digitalcorpora.org/corp/files/govdocs1/by_type/doc.zip and with this file (in attachement) I have this stacktrace
stacktrace.txt

the olefile for the test is:

012153.doc.zip

The code has a recursion in apend_kids method: the child_sid = 0 for each turn of loop.

child_sid = 0 is a limit case ?

Seb
christian-intra2net added a commit to christian-intra2net/oletools that referenced this issue Jul 22, 2016
@christian-intra2net
fixed bug that caused infinite recursion in str(UnexpectedDataError)
fbfd20e 
(may be related to Issue decalage2#66 on github)
@christian-intra2net
Copy link
Contributor

I was a bit too quick referencing this issue in my pull request -- your problem seems to have another reason :-(

@sebdraven
Copy link
Contributor Author

I've fixed the problem like that: https://github.com/sebdraven/oletools/blob/master/oletools/thirdparty/olefile/olefile.py#L1037

@decalage2 decalage2 added this to the oletools 0.60 milestone Jul 28, 2016
@decalage2 decalage2 self-assigned this Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decalage2 decalage2

Labels
🐛 bug major olefile
Projects
None yet
Milestone
Future Releases
Development

No branches or pull requests
3 participants
@sebdraven @decalage2 @christian-intra2net