Fix #117: license info throwing error and breaking Promise #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
escaped \n in the regex check, as the string to test is using \n as string. this fixes an issue where the "license accepted" info message would throw an error.
moved the license-accepted error check into the same if/else conditional for readability.
|
@ddsol is anything missing, for it to get fixed? happy to help out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #117
The regex check on line 279 never stuck, due to it testing for
\n, instead of the escaped string version.Changes:
Reproduce:
use vscode
ms-vscode-remote.remote-containersextension, to run it in a fresh container -> this will require accepting the license, and throw the error.I've added a temporary
run.jslocally, where I execute the package and attach to it via node debugger in vscode. (breakpoint line 277). Then its fairly clear that the regex that supposedly should clear the error, does not work.