Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow integers in numeric class checks #1868

Merged
merged 6 commits into from
Jul 24, 2024
Merged

Conversation

edelarua
Copy link
Collaborator

@edelarua edelarua commented Jul 24, 2024

What changes are proposed in this pull request?

  • When checking that the class of a value is numeric, also allow integers.

Closes #1867


Reviewer Checklist (if item does not apply, mark is as complete)

  • Ensure all package dependencies are installed: renv::install()
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# gtsummary (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (see NEWS.md for examples).
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

@edelarua edelarua requested a review from ddsjoberg July 24, 2024 15:25
@ddsjoberg
Copy link
Owner

Thank you @edelarua for the quick fix!! 🙇🏼‍♂️

Can we add one unit test, then we can go ahead and merge?

@edelarua
Copy link
Collaborator Author

@ddsjoberg unit test added :)

Copy link
Owner

@ddsjoberg ddsjoberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @edelarua !!

@ddsjoberg ddsjoberg merged commit 0a11efb into main Jul 24, 2024
7 checks passed
@ddsjoberg ddsjoberg deleted the check_class_integer_bug branch July 24, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: tbl_survfit() fails when times is an integer
2 participants