Add reason for why developers might not include in Gemfile #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
andrewmcodes
suggested changes
Apr 1, 2019
|
Fixed |
|
I also agree it would be useful to provide some context. But even with this PR - I'm still not clear on the risk of adding to the Gemfile. Would it be possible to get some further explanation please? |
|
I highly suggest that you do not include https://github.com/ddollar/foreman/wiki/Don't-Bundle-Foreman |
|
That doesn't resolve the purpose of this PR but 🤷. |
|
Added the link to the README here: 14bf253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the message has changed over the years but originally stems from this comment. Instead of flatley rejecting the idea, specify why dev might want to avoid it so they can decide for themselves.