Adding Key Value producer method "send(Map<String, String> ..)" #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
The key-value pair Consumer option does not have a corresponding Producer method.
Story
Developer: "I want to create a producer that can send to SomeConsumer, but I don't have the documentation, lets look at the source."
Developer: "Oh, I get it, I just need to send a Map like this."
Forklift:
validation failed
Developer: ???
Explanation
The map was serialized as JSON in the Producer, but deserialized as key-value pairs on the Consumer, even though they share the same type.)
Fix
Add an additional
send(...)
method so that sending a Map<String, String> serializes to key-value pairs instead of JSON.Testing/Deployment
This changes both forklift connector plugin API and the forklift plugins that depend on it. It requires that you locally deploy a new forklift core before you build or test the ActiveMQProducer plugin.