Allow named injections #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adispennette
reviewed
Sep 3, 2020
| @@ -401,7 +402,9 @@ private final void configureConstructorInjection() { | |||
| fields.get(clazz).forEach(field -> { | |||
| log.trace("Inject target> Field: ({}) Decorator: ({})", field, decorator); | |||
| try { | |||
| Object value = getInjectableValue(field.getAnnotation(decorator), field.getName(), clazz, msg); | |||
| String fieldName = Optional.ofNullable(field.getAnnotation(Named.class)) | |||
| .map(a -> a.value()).orElse(field.getName()); | |||
There was a problem hiding this comment.
do you want orElse or orElseGet? orElse is always executed where as orElseGet is not
adispennette
approved these changes
Sep 3, 2020
AFrieze
reviewed
Sep 8, 2020
| @@ -224,6 +229,49 @@ public void testHeadersAndProperties() { | |||
| assertEquals(ec.producer, "testing"); | |||
| } | |||
|
|
|||
| // For the next two tests, we are testing named dependency injection. | |||
There was a problem hiding this comment.
Minor Opinion: This comment seems a little brittle in that code methods could move
AFrieze
reviewed
Sep 8, 2020
| static Map<String, Person> map = new HashMap<>(); | ||
|
|
||
| @BeanResolver | ||
| public Object resolve(Class<?> requestedClass, String name){ |
There was a problem hiding this comment.
Does scope matter at all? It looks like if we have a named bean then we are applying Singleton scope and if we have a non-named bean we are creating new instances on every request
There was a problem hiding this comment.
This is fine, since it it only being used in the tests to prove that the named annotation resolver can be used successfully. This is not production level code.
AFrieze
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.