Upgrade to junit5 #158
Merged
Upgrade to junit5 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuroshii
approved these changes
Aug 5, 2020
| } | ||
|
|
||
| @Test | ||
| public void testEqualsWorksNormally() { | ||
| final String testTopic = "test-topic"; | ||
| final String testGroup = "test-group"; | ||
| Assert.assertEquals(new GroupedTopicSource(testTopic, testGroup), | ||
| assertEquals(new GroupedTopicSource(testTopic, testGroup), | ||
| new GroupedTopicSource(testTopic, testGroup)); |
There was a problem hiding this comment.
Nit: some classic refactor misalignment in a couple of these tests
GroupedTopicSourceTest
QueueSourceTest
RoleInputSourceTest
RoleInputMessageTests
TopicSourceTest
| public void testNullArrayDeployment() throws IOException { | ||
| assertThrows(NullPointerException.class, () -> { | ||
| new ClassDeployment((Class<?>[]) null); |
|
|
||
| final ForkliftMessage extractedMessage = consumerWrapper.receive(1000); | ||
| consumerWrapper.receive(1000); |
| import org.junit.Assert; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import static org.junit.jupiter.api.Assertions.assertArrayEquals; |
There was a problem hiding this comment.
static import in the middle, that's new
applitect
force-pushed
the
upgrade-to-junit5
branch
from
0bc9fd4
to
797fbad
Compare
|
Rebased with develop. Fixed up nits and spacing issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to upgrade. Like the assertThrows vs the expected in the annotation.