-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to gradle #154
Convert to gradle #154
Conversation
…ith gradle 6.5. Add the signing plug-in and get it working so we can sign the all the packages.
Don't need a build.gradle in sbt specific project.
connectors/activemq/build.gradle
Outdated
@@ -0,0 +1,9 @@ | |||
dependencies { | |||
api project(':forklift-core'), | |||
'org.apache.activemq:activemq-client:5/14.0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 5.14.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, wondering how it worked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet bringing in the broker brought in the client correctly. But fixing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple questions, but I see nothing that cannot be merged down. Thanks for the update! I think everyone is sick of sbt! :)
jdk: | ||
- oraclejdk8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be sure to note this in the release notes. "No longer support jdk8"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already got another branch going for updating docs for the next release.
Has been tested and have been able to deploy a snapshot version of 3.8 to sonatype oss. Deploys in the same structure as the sbt deploy.