Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to gradle #154

Merged
merged 33 commits into from
Jul 21, 2020
Merged

Convert to gradle #154

merged 33 commits into from
Jul 21, 2020

Conversation

applitect
Copy link
Collaborator

  • Rewrite the build framework to go from sbt to gradle.
  • Update to release with Java 11.
  • Minor javadoc fixes to allow it to compile with Java 11.

Has been tested and have been able to deploy a snapshot version of 3.8 to sonatype oss. Deploys in the same structure as the sbt deploy.

…ith gradle 6.5.

Add the signing plug-in and get it working so we can sign the all the packages.
Don't need a build.gradle in sbt specific project.
@@ -0,0 +1,9 @@
dependencies {
api project(':forklift-core'),
'org.apache.activemq:activemq-client:5/14.0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 5.14.0?

Copy link
Collaborator Author

@applitect applitect Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, wondering how it worked.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet bringing in the broker brought in the client correctly. But fixing.

Copy link
Owner

@dcshock dcshock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple questions, but I see nothing that cannot be merged down. Thanks for the update! I think everyone is sick of sbt! :)

jdk:
- oraclejdk8
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be sure to note this in the release notes. "No longer support jdk8"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already got another branch going for updating docs for the next release.

connectors/activemq/build.gradle Outdated Show resolved Hide resolved
server/build.gradle Show resolved Hide resolved
@applitect applitect merged commit 78f3426 into develop Jul 21, 2020
@applitect applitect deleted the convert-to-gradle branch July 29, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants