Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify consumer method annotations to be detected on superclasses #148

Closed
wants to merge 1 commit into from
Closed

Modify consumer method annotations to be detected on superclasses #148

wants to merge 1 commit into from

Conversation

yashton
Copy link

@yashton yashton commented May 10, 2018

For consumers with a high degree of shared boilerplate on consumer methods, creating a base class to abstract the boilerplate fails because the annotations only are detected on direct members of the consumer. Allowing forklift to detect annotations on super classes and interfaces solves this issue.

@dcshock
Copy link
Owner

dcshock commented Jul 17, 2020

@applitect I completely missed this as I haven't been the maintainer in quite some time. We should definitely get this in place, but it'll require a quick update to freshen it up with the latest dev version. Is this something you can take on?

@applitect
Copy link
Collaborator

This branch is not valid. Methods and fields are not supported by @inherited. That is only supported for classes. Thus the unit tests in OnDecorator fail and the methods can not be found for things like OnMessage, etc.

@applitect applitect closed this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants