Add missing heartbeat to kafka controller #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuroshii
reviewed
Dec 20, 2017
| @@ -186,8 +186,9 @@ private void controlLoop() { | |||
| synchronized (this) { | |||
| //wait for flowControl to notify us, resume after a short pause to allow for heartbeats | |||
| this.wait(100); | |||
| //Heartbeat is sent on poll. This call should not return records. | |||
| return kafkaConsumer.poll(1); | |||
There was a problem hiding this comment.
For this, poll(0) should be better (assuming this is supposed to be avoiding a busy loop). From the javadoc for KafkaConsumer#poll:
* @param timeout The time, in milliseconds, spent waiting in poll if data is not available in the buffer.
* If 0, returns immediately with any records that are available currently in the buffer, else returns empty.
* Must not be negative.
The heartbeat that is triggered by polling the ConsumerCoordinator is completely asynchronous (it is sent from the coordinator's heartbeat thread), so it is realistic that poll(0) might do a few loops through pollOnce.
Kuroshii
approved these changes
Dec 20, 2017
dcshock
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.