Feature/use reader schema for specific records #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2017 14:07
dcshock
reviewed
Nov 27, 2017
| * @throws ConnectorException if an error occurred interacting with the connector | ||
| * @throws RuntimeException if reading from a queue is not supported | ||
| */ | ||
| ForkliftConsumerI getQueue(String name) throws ConnectorException; |
There was a problem hiding this comment.
Might be good to stub these in to call getConsumerForSource to avoid backward compatibility issues.
There was a problem hiding this comment.
How much of a concern is this given that these methods are mostly internal? My rationale for removing these is that more and more functionality is moving into the "Source" concept and if keep these methods around we could have diverging logic in places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KafkaAvroDeserializer uses the writer schema retrieved from the incoming message to deserialize messages into GenericRecords. This leads to default values in a newer Reader schema being ignored. This PR adds a new deserializer that is configured with the appropriate reader schema based off a source. It is worth noting that this PR removes the
getQueue(String name)andgetTopic(String name)from the ForkliftConnector interface.