Kafka Connector: Consumer Topic + Grouped Topic Support #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuroshii
force-pushed
the
kafka-topic-and-grouped-topic-support
branch
from
5ce9869
to
9a6817a
Compare
dkessler-sofi
approved these changes
Oct 18, 2017
|
@Kuroshii can you add a release note to the README and update the version for release? Thanks |
Kuroshii
force-pushed
the
kafka-topic-and-grouped-topic-support
branch
from
9a6817a
to
34dd22b
Compare
Kuroshii
force-pushed
the
kafka-topic-and-grouped-topic-support
branch
2 times, most recently
from
f12a7f1
to
2190542
Compare
Kuroshii
force-pushed
the
kafka-topic-and-grouped-topic-support
branch
from
2190542
to
20b3900
Compare
|
@Kuroshii is this something that we'd like to get merged in? I'm not familiar enough with the kafka connector to make the assessment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
KafkaControllerinstances based on both topic name and the chosen groupId for a topic this way, each differentGroupedTopicSources gets it's own underlyingKafkaConsumerTopicSourceis identified by both the default groupId and it's class's nameI ran all the tests locally and they all eventually passed after a rerun and 2GB of memory. Having another look at our integration tests is a good idea.
Please Review: @seanmrogers @dkessler-sofi @AFrieze