Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/forklift kafka #125

Merged
merged 118 commits into from
Apr 10, 2017
Merged

Wip/forklift kafka #125

merged 118 commits into from
Apr 10, 2017

Conversation

AFrieze
Copy link
Collaborator

@AFrieze AFrieze commented Mar 30, 2017

Add support for kafka

Matt Conroy and others added 30 commits March 23, 2017 20:20
- Remove unused AuditLog.java
54d1f58 
- Implement non-jms versions of the forklift connector and message.
We'll use the java8 functional interfaces at this point and force any…
9760da7 
…one using the program to upgrade to java8
- Adjust to use forklift message objects rather than jms.
268493e
- Bring in ack modifications that don't depend on jms.
ad8ef99
- Update the producer interface to remove jms and mod props to string…
bc26a5c 
… values.
- Update Consumer to not use jms specific code
3aae460
- Fix compile errors.
e88b358
- Update version.
f7a5ea5
- Add the kafka connector from Andrew F.
6217876
- Update to use the latest version of forklift.
d7b510f
- Remove the unused forklift message converter method. It's now in th…
255db37 
…e consumer
- Add vscode.
e2d583b
- Fixup core tests due to forklift message changes.
d7e75da
- Add the jms spec
e4a570e
- Fixups from the latest version of core.
37abb05
- test fixups
bf09f50
- Change some bool logic to be javaesque
b27210b
- Update tests/code to pass with the latest version of forklift that …
8c85ead 
…ignores the broker type.
- Store LifeCycleMonitors at the Forklift level so that it doesn't ha…
e1ac7b9 
…ve to be static. This allows multiple forklift instances to be started in a given jvm using different connectors.
- Update tests to work with the per forklift instance life cycle moni…
a07522c 
…tors.
- Update to v1.0 - This release is not backward compatible and will r…
7d2a982 
…equire some minor code changes on the implementation side.

-
- Upgrade to forklift 1.0
0f8407a
- Expose the Forklift instance from the server. It is necessary in or…
034b362 
…der to build applications that utilize the forklift construct directly for producers.
More efficient use of entrySet iterator
154c169
Removed unused variable
715d842
More efficient use of entrySet iterator over keySet
2a608c7
Explicitely setting value to null for readability
37e3dfd
More efficient use of entrySet iterator rather than keySet
2717d01
Moved expected condition's log from error to info
d6b5509
Made synchronization of kafkaProducer consistent
c06656a
Andrew Frieze and others added 14 commits April 3, 2017 10:35
Removed unnecessary null checks
cf7e9d1
Moved Override annotation to its own line
a743db1
Additional comments and changed an assignment for readabilty
5fbc3ef
Cleaned up readme
998ed47
@bhowellsofi @Kuroshii
Use all of the configurations constants, separate forklift message sc…
5939943 
…hema into its own file
@Kuroshii
Merge branch 'wip/forklift-kafka' of https://github.com/dcshock/forklift
c65d451 
 into wip/forklift-kafka
corrected javadoc
ae01d98
Formatted file
ca7e0fa
Merge branch 'wip/forklift-kafka' of https://github.com/dcshock/forklift
daa61d1 
 into wip/forklift-kafka
@Kuroshii
Some avro refactors and cleanup
474d2fc
@Kuroshii
Merge branch 'wip/forklift-kafka' of https://github.com/dcshock/forklift
1a83c65 
 into wip/forklift-kafka
@Kuroshii
Go back to generated-sources
16da152
@Kuroshii
Unbreak from avro changes
5373106
@Kuroshii
Some tidying up
7903c38
Kuroshii
Kuroshii approved these changes Apr 3, 2017
View reviewed changes
Copy link
Collaborator

@Kuroshii Kuroshii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more polished than before; let's proceed

Matt Conroy and others added 13 commits April 3, 2017 14:17
@dcshock dcshock merged commit 74d7efd into develop Apr 10, 2017
@Kuroshii Kuroshii deleted the wip/forklift-kafka branch June 9, 2017 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kuroshii Kuroshii Kuroshii approved these changes

@dcshock dcshock Awaiting requested review from dcshock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AFrieze @Kuroshii @dcshock @bhowellsofi