ExecutorThreadPool: increase request queue size and increase corePoolSize #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgehrcke
approved these changes
Feb 22, 2017
|
I think 20 (1 thread per core for 12-core machines + 8 acceptor threads) is probably enough. I'll test and decrease if it works. |
b9779fc
to
6e1a899
Compare
|
Setting the |
rdeliallisi
pushed a commit
to rdeliallisi/exhibitor
that referenced
this pull request
Jul 31, 2017
StandardProcessOperations: fix getMonitoredHost call, more logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Acceptor threads come from the same ExecutorThreadPool that requests are served with, which leads to severe contention when there are 8 Acceptor threads active and the ExecutorThreadPool doesn't want to grow the pool past the
corePoolSize.Why the thread pool is limited to the
corePoolSizeand does not want to grow tomaximumPoolSizeI don't know. We set thecorePoolSizeto 20 here and that seems to fix the problem. We also increase the requests queue size to 4096 to guard against network latency hiccups between exhibitor nodes causing the queue to spike temporarily.Fixes https://jira.mesosphere.com/browse/DCOS-14045