Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to disable camera ping loop #43

Closed
wants to merge 2 commits into from

Conversation

CamSoper
Copy link

@CamSoper CamSoper commented Oct 8, 2021

Added an environment variable that indicates if the loop that pings the camera should be started. Myself and others have had problems with that ping causing the container to restart excessively.

The loop defaults to on. The environment variable is only necessary if you want to disable the ping.

Edit: Closing this to get it out of my "open PRs" list. The change is trivial, if anyone wants to make it locally and build a custom Docker image. Personally I replaced this container with the Dahua integration in HASS and it works perfectly.

@CamSoper
Copy link
Author

Hi @dchesterton! Are there any questions about this PR? I've been merging your changes into my fork. I would really love if this change just got merged into the main branch.

@CamSoper
Copy link
Author

Meh, screw it. Feel free to reopen. 🙂

@CamSoper CamSoper closed this Feb 17, 2022
@dchesterton
Copy link
Owner

Thanks for the PR but to be honest, I've not been happy with the ping solution in general and I've been looking at a better way to handle connections. Thankfully the latest version of the python-amcrest library raises a proper exception if/when the stream breaks so I've updated the app to use and removed the pinging functionaltiy entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants