Merge pull request #4 from jalaj-k/iss_2

Fix #2
dcadarko · Aug 31, 2020 · c738e28 · c738e28
2 parents 5131a1c + c6e697c
commit c738e28
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 27 deletions.
diff --git a/package.json b/package.json
@@ -11,7 +11,6 @@
  "@testing-library/jest-dom": "^4.2.4",
  "@testing-library/react": "^9.5.0",
  "@testing-library/user-event": "^7.2.1",
- "clsx": "^1.1.1",
  "date-fns": "^2.15.0",
  "react": "^16.13.1",
  "react-dom": "^16.13.1",

diff --git a/public/index.html b/public/index.html
@@ -10,20 +10,9 @@
  content="Web site created using create-react-app"
  />
  <link rel="apple-touch-icon" href="%PUBLIC_URL%/logo192.png" />
- <!--
- manifest.json provides metadata used when your web app is installed on a
- user's mobile device or desktop. See https://developers.google.com/web/fundamentals/web-app-manifest/
- -->
+
  <link rel="manifest" href="%PUBLIC_URL%/manifest.json" />
- <!--
- Notice the use of %PUBLIC_URL% in the tags above.
- It will be replaced with the URL of the `public` folder during the build.
- Only files inside the `public` folder can be referenced from the HTML.
-
- Unlike "/favicon.ico" or "favicon.ico", "%PUBLIC_URL%/favicon.ico" will
- work correctly both with client-side routing and a non-root public URL.
- Learn how to configure a non-root public URL by running `npm run build`.
- -->
+
  <title>React App</title>
  <style>
  body {
@@ -44,7 +33,6 @@
 
  main{
  overflow-y: auto;
- max-height: calc(100vh - 70px);
  }
 
  a {
@@ -55,15 +43,6 @@
  <body>
  <noscript>You need to enable JavaScript to run this app.</noscript>
  <div id="root"></div>
- <!--
- This HTML file is a template.
- If you open it directly in the browser, you will see an empty page.
-
- You can add webfonts, meta tags, or analytics to this file.
- The build step will place the bundled scripts into the <body> tag.
-
- To begin the development, run `npm start` or `yarn start`.
- To create a production bundle, use `npm run build` or `yarn build`.
- -->
+
  </body>
 </html>
diff --git a/src/components/TodoItem.js b/src/components/TodoItem.js
@@ -17,7 +17,6 @@ import {
  EditOutlined,
  ExpandMoreOutlined,
 } from "@material-ui/icons"
-import clsx from "clsx"
 
 class TodoItem extends React.Component {
  constructor(props) {

diff --git a/src/pages/create.js b/src/pages/create.js
@@ -227,7 +227,7 @@ class CreateNew extends React.Component {
 
  render() {
  return (
- <div>
+ <div className={this.props.classes.root}>
  <form autoComplete="false">
  <TextField
  className={this.classes.input}
@@ -365,6 +365,7 @@ class CreateNew extends React.Component {
 export default withStyles(theme => ({
  root: {
  display: "block",
+ maxHeight: "calc(85vh - 70px)"
  },
  formControl: {
  margin: theme.spacing(1),

diff --git a/src/pages/lists.js b/src/pages/lists.js
@@ -188,6 +188,7 @@ class List extends React.Component {
 export default withStyles(theme => ({
  root: {
  display: "block",
+ maxHeight: "80vh"
  },
  grow: {
  flexGrow: 1,