Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hub.json #203

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Update hub.json #203

merged 1 commit into from
Nov 17, 2022

Conversation

tuvaforrest
Copy link
Contributor

Hi! A few changes here as part of our code refactor:

  • we renamed our "core" package to "the_tuva_project" (once the other packages are on dbt hub, we'll do a new release for this repo that will transform it into a mono-package implementing the rest of the packages)
  • added data_profiling
  • added claims_preprocessing
  • removed medicare_claims_connector (for now, we're going to be using this repo as a project) -- note, something weird happened, I think when we renamed the medicare_claims_connector repo and named it back, dbt-hub now shows medicare_cclf_connector and medicare_claims_connector, even though only medicare claims_connector is in hubcap.json. They can both be removed.

Hi!  A few changes here as part of our code refactor:
- we renamed our "core" package to "the_tuva_project" (once the other packages are on dbt hub, we'll do a new release for this repo that will transform it into a mono-package implementing the rest of the packages)
- added data_profiling
- added claims_preprocessing
- removed medicare_claims_connector (for now, we're going to be using this repo as a project)
-- note, something weird happened, I think when we renamed the medicare_claims_connector repo and named it back, dbt-hub now shows medicare_cclf_connector and medicare_claims_connector, even though only medicare claims_connector is in hubcap.json.  They can both be removed.
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tuvaforrest 👋

Thanks for the explanations!

Here's what we'll over in the hub.getdbt.com repo do after this PR is merged:

  1. We already renamed the original "tuva" package to "core" with this PR, so we'll just do the same kind of thing again to finish renaming it to "the_tuva_project" within the Hub.
    • Files to update:
      1. data/packages/tuva-health/tuva/index.json
      2. data/packages/tuva-health/core/index.json
      3. data/blocklist.json
  2. Add both "medicare_cclf_connector" and "medicare_claims_connector" to the blocklist
    • Files to update:
      1. data/blocklist.json

@dbeatty10
Copy link
Contributor

Two checks aren't passing:

image

  1. The former is because of Flake8 took down the gitlab repository in favor of github #204, and
  2. the latter has been cropping up randomly lately.

But since this PR passes my eye test 👀, it's low risk & impact, and I don't want to futz with the details of making this green, I'm shipping it 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants