-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parse group config on groupable nodes #6965
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
4911ccc
to
f17b360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far. I do have a couple of questions-- Are we going to "promote" the group config to node level in update_node_config? Are generic tests actually going to be able to be assigned to groups? I'm wondering if it might not make more sense for generic tests to belong to the group of the node they're attached to.
Agreed! This also makes sense given |
8c52e6d
to
36cd196
Compare
36cd196
to
a71b158
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments to make this more Pythonic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, keeping this pattern for now.
1bda433
to
a761fc3
Compare
a761fc3
to
5414a3b
Compare
af04cb4
to
ff2938e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I see what you meant about combining the ref_lookup and disabled. This actually feels like a somewhat better solution than in other places where it's two separate lookups.
resolves #6823
Description
Checklist
changie new
to create a changelog entry