Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing exposure error #6934

Merged
merged 2 commits into from
Feb 15, 2023
Merged

Fixing exposure error #6934

merged 2 commits into from
Feb 15, 2023

Conversation

callum-mcdata
Copy link
Contributor

resolves #6928

Description

Resolves an issue in the manifest parsing file where we were providing a string that was the wrong node type.

Checklist

@callum-mcdata callum-mcdata requested review from a team as code owners February 10, 2023 14:48
@cla-bot cla-bot bot added the cla:yes label Feb 10, 2023
@callum-mcdata callum-mcdata mentioned this pull request Feb 10, 2023
Closed
2 tasks
emmyoop
emmyoop approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emmyoop emmyoop merged commit 57ce461 into main Feb 15, 2023
@emmyoop emmyoop deleted the fixing-exposure-error branch February 15, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@MichelleArk MichelleArk Awaiting requested review from MichelleArk MichelleArk was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-2074] [Bug] Error message for exposures gives incorrect node type for TargetNotFound
3 participants
@callum-mcdata @emmyoop @jtcohen6