Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gogs git provider #1255

Merged
merged 5 commits into from
Oct 21, 2024
Merged

feat: add gogs git provider #1255

merged 5 commits into from
Oct 21, 2024

Conversation

tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented Oct 16, 2024 •
edited
Loading

add gogs git provider

Description

This PR adds support for a new Git provider gogs

  • This change requires a documentation update
  • I have made corresponding changes to the documentation

Related Issue(s)

Related docs PR: daytonaio/docs#179
closes #1223

Screenshots

manual
image

via TUI
https://github.com/user-attachments/assets/30075f54-34ce-4fa7-92a0-6391e598ac66

commit
image

@quest-bot loot #1223

@tarunrajput tarunrajput requested review from a team as code owners October 16, 2024 09:24
@tarunrajput tarunrajput force-pushed the feat/add-gogs-gp branch 2 times, most recently from 2ef1bbe to 834135b Compare October 16, 2024 09:27
@tarunrajput
Copy link
Contributor Author

@quest-bot loot #1223

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 16, 2024
@quest-bot quest-bot bot mentioned this pull request Oct 16, 2024
Closed
@quest-bot quest-bot
Copy link

quest-bot bot commented Oct 16, 2024

Quest PR submitted! image Quest PR submitted!

@tarunrajput, you are attempting to solve the issue and loot this Quest. Will you be successful?

Questions? Check out the docs.

Tpuljak
Tpuljak requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good generally. I'll test it out a bit later

pkg/server/gitproviders/service.go Outdated Show resolved Hide resolved
pkg/views/gitprovider/select.go Outdated Show resolved Hide resolved
cmd/daytona/config/const.go Outdated Show resolved Hide resolved
Tpuljak
Tpuljak requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarunrajput nice work! Most of the code works great! Left a few comments that we should address before moving forward.

pkg/gitprovider/gogs.go Show resolved Hide resolved
cmd/daytona/config/const.go Show resolved Hide resolved
pkg/gitprovider/gogs.go Show resolved Hide resolved
@tarunrajput tarunrajput force-pushed the feat/add-gogs-gp branch 2 times, most recently from 939b74e to 68b7bda Compare October 16, 2024 15:51
@tarunrajput tarunrajput mentioned this pull request Oct 16, 2024
Merged
Tpuljak
Tpuljak requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more general note: Please don't force push into a PR when you receive a review. Add a separate commit that addresses that review and then we squash everything when we merge the PR. This makes it easier for us to track changes.

pkg/server/gitproviders/gitprovider.go Outdated Show resolved Hide resolved
@tarunrajput tarunrajput force-pushed the feat/add-gogs-gp branch 2 times, most recently from c755f7a to 6a16638 Compare October 18, 2024 06:07
Tpuljak
Tpuljak requested changes Oct 18, 2024
View reviewed changes
pkg/server/gitproviders/gitprovider.go Outdated Show resolved Hide resolved
Tpuljak
Tpuljak approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@Tpuljak Tpuljak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@idagelic idagelic merged commit 80718f8 into daytonaio:main Oct 21, 2024
12 checks passed
@quest-bot quest-bot
Copy link

quest-bot bot commented Oct 21, 2024

🧚 @tarunrajput congratulations for completing Quest #1223

💰 A reward of $45 has been credited to you.

To claim your $45 reward follow the instructions here.

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tpuljak Tpuljak Tpuljak approved these changes

@idagelic idagelic idagelic approved these changes

Assignees
No one assigned
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for gogs git provider
3 participants
@tarunrajput @idagelic @Tpuljak