Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON output flag breaks select TUI #688

Open
Tpuljak opened this issue Jun 17, 2024 · 9 comments
Open

JSON output flag breaks select TUI #688

Tpuljak opened this issue Jun 17, 2024 · 9 comments
Labels
💎 Bounty bug Something isn't working never stale An issue that never goes stale

Comments

@Tpuljak
Copy link
Member

Tpuljak commented Jun 17, 2024

Describe the bug
When the -o json flag is added, the selection TUI seems to break completely. A video is provided in the screenshots section

To Reproduce
Steps to reproduce the behavior:

  1. Run the Daytona Server
  2. Run daytona info -o json (or daytona code -o json)
  3. Observe that the selection TUI is blank

Expected behavior
The user should be able to select a workspace from the TUI list (the same behavior as with daytona info).

Screenshots
https://github.com/daytonaio/daytona/assets/26512078/d049aedd-2eb4-40e0-bf7f-2bb46f31bd51

Desktop (please complete the following information):

  • OS: any
  • Daytona Version: v0.19.1
@Tpuljak Tpuljak added bug Something isn't working never stale An issue that never goes stale backlog backlog until further notice labels Jun 17, 2024
@RS-labhub
Copy link
Contributor

RS-labhub commented Jun 18, 2024

Hey @Tpuljak. That screenshot link in not working 😅

By the way, as per my understading, What if you add a check for the -o json flag and handle the output accordingly??

@Tpuljak
Copy link
Member Author

Tpuljak commented Jun 18, 2024

@RS-labhub the link seems to work for me, it downloads the file and I can play it locally.

By the way, as per my understading, What if you add a check for the -o json flag and handle the output accordingly??

That's the idea. There seems to be an issue with displaying the TUI while the flag is set. You're welcome to tackle the issue and raise a PR

@RS-labhub
Copy link
Contributor

@RS-labhub the link seems to work for me, it downloads the file and I can play it locally.

It's throwing me this: "this site can't be reached".
Don't know why, I'm able to upload the screenshot 🙂

That's the idea. There seems to be an issue with displaying the TUI while the flag is set. You're welcome to tackle the issue and raise a PR
A silly question, where should I add the code? in cmd/Daytona > main.go or cmd/Daytona > congif > config.go?? 😅

@Tpuljak
Copy link
Member Author

Tpuljak commented Jun 18, 2024

A silly question, where should I add the code? in cmd/Daytona > main.go or cmd/Daytona > congif > config.go?? 😅

Try to figure that out while working on the PR.

It's throwing me this: "this site can't be reached".
Don't know why, I'm able to upload the screenshot 🙂

Simply run daytona info -o json and you should see a blank screen.

@RS-labhub
Copy link
Contributor

Oh okay... Trying!

@idagelic idagelic removed the backlog backlog until further notice label Jul 17, 2024
@idagelic
Copy link
Member

/bounty $30

Copy link

algora-pbc bot commented Jul 17, 2024

💎 $60 bounty • Daytona

Steps to solve:

  1. Start working: Comment /attempt #688 with your implementation plan
  2. Submit work: Create a pull request including /claim #688 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Please respect others by working on PRs that you are allowed to submit attempts to.

e.g. If you reached the limit of active attempts, please wait for the ability to do so before submitting a new PR.

If you can not submit an attempt, you will not receive your payout.

Thank you for contributing to daytonaio/daytona!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @joey1123455 Jul 26, 2024, 11:03:01 PM #849

@joey1123455
Copy link
Contributor

joey1123455 commented Jul 26, 2024

/attempt #688

Algora profile Completed bounties Tech Active attempts Options
@joey1123455 1 daytonaio bounty
Less, Go
Cancel attempt

Copy link

algora-pbc bot commented Jul 27, 2024

💡 @joey1123455 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty bug Something isn't working never stale An issue that never goes stale
Projects
None yet
Development

No branches or pull requests

4 participants