-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TUI breaking under pressure #668
Comments
Hello @nkkko , I have seen some more issues with the filter ('/') command while fixing #592 .. Overall, I have found the fix and will push a MR if its ok to do so.. |
@abhishek818 That sounds good - feel free to open up a PR for any potential fix and we will take a look. Thank you! |
set a max height for workspace selection view.
set a max height for workspace selection view. Signed-off-by: Abhishek Kumar Gupta <[email protected]>
Leaving this open as the issue where the cursor ends up on the bottom of the view disallowing the user to select items still exists. |
/bounty $30 |
💎 $100 bounty • DaytonaSteps to solve:
If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code. Please respect others by working on PRs that you are allowed to submit attempts to. e.g. If you reached the limit of active attempts, please wait for the ability to do so before submitting a new PR. If you can not submit an attempt, you will not receive your payout. Thank you for contributing to daytonaio/daytona! |
@bryans-go can you please let us know how to reproduce this? |
@Tpuljak I used Daytona list on one tab and Daytona create on other tab of the terminal. Which leads to pressure on tui . And the following happened |
These are all the steps for reproduction? I tried it out and found no issues. Also, the list command does not run indefinitely, it executes immediately so I am curious on how that would make a difference. Can you please try the reproduction once again and update the steps if necessary? I am also testing on Windows Terminal |
@idagelic So we can conclude that TUI only breaks on custom themes terminal like this terminal app on windows 11. I had a wsl theme which is supplied officially by the windows in order to open wsl instance . also in the start of the issue you said you used Alacritty, along with OMZ . this is a issue with charmbracelet huh or the custom terminals |
I remember reading few issues on github stating problems with bubbletea tui breaking specifically on alacrity terminal with no apparent fix mentioned. I am guessing it's the problem with the library on certain terminals. |
@abhishek818 do you mind sharing references or links to those issue here |
The thing is that I have this issue appear on my setup as well, maybe every hundredth open of |
Describe the bug
TUI breaks on random points, especially when searching the repo by hitting "/". Check the gif recording. I have observed weirdness in other spots #665 also.
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: