Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI breaking under pressure #668

Open
nkkko opened this issue Jun 11, 2024 · 16 comments · Fixed by #725
Open

TUI breaking under pressure #668

nkkko opened this issue Jun 11, 2024 · 16 comments · Fixed by #725
Assignees
Labels
💎 Bounty bug Something isn't working help wanted Extra attention is needed never stale An issue that never goes stale

Comments

@nkkko
Copy link
Member

nkkko commented Jun 11, 2024

Describe the bug
TUI breaks on random points, especially when searching the repo by hitting "/". Check the gif recording. I have observed weirdness in other spots #665 also.

Screenshots
daytona_tui

Desktop (please complete the following information):

  • OS: MacOs Sonoma
  • Terminal: Alacritty, OMZ
  • Daytona Version: 0.18.0
@nkkko nkkko added the bug Something isn't working label Jun 11, 2024
@Tpuljak Tpuljak added the never stale An issue that never goes stale label Jun 11, 2024
@nkkko
Copy link
Member Author

nkkko commented Jun 11, 2024

one more gif with a bit different break, hitting enter on my github
daytona_tui2

@abhishek818
Copy link
Contributor

TUI breaks on random points, especially when searching the repo by hitting "/". Check the gif recording.

Hello @nkkko , I have seen some more issues with the filter ('/') command while fixing #592 ..
I find filter input text gets printed twice if there is a match and the duplicated input doesnt goes away even on pressing 'Esc' (this happens everytime in full screen terminal mode). The one you mentioned where '//////...' gets printed in the footer is very rare occurence.

Overall, I have found the fix and will push a MR if its ok to do so..
CC: @Tpuljak @idagelic tagging code reviewers.

daytona_tui_filter_Screenshot_2024-07-04

@idagelic
Copy link
Member

idagelic commented Jul 4, 2024

@abhishek818 That sounds good - feel free to open up a PR for any potential fix and we will take a look. Thank you!

abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 4, 2024
set a max height for workspace selection view.
@abhishek818
Copy link
Contributor

@idagelic have opened a PR for TUI ui related fixes.

abhishek818 added a commit to abhishek818/daytona that referenced this issue Jul 4, 2024
set a max height for workspace selection view.

Signed-off-by: Abhishek Kumar Gupta <[email protected]>
@idagelic idagelic reopened this Jul 10, 2024
@idagelic
Copy link
Member

Leaving this open as the issue where the cursor ends up on the bottom of the view disallowing the user to select items still exists.

@idagelic idagelic added backlog backlog until further notice and removed backlog backlog until further notice labels Jul 15, 2024
@idagelic
Copy link
Member

/bounty $30

Copy link

algora-pbc bot commented Jul 17, 2024

💎 $100 bounty • Daytona

Steps to solve:

  1. Start working: Comment /attempt #668 with your implementation plan
  2. Submit work: Create a pull request including /claim #668 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Please respect others by working on PRs that you are allowed to submit attempts to.

e.g. If you reached the limit of active attempts, please wait for the ability to do so before submitting a new PR.

If you can not submit an attempt, you will not receive your payout.

Thank you for contributing to daytonaio/daytona!

Add a bountyShare on socials

@lbrecic lbrecic added the help wanted Extra attention is needed label Aug 29, 2024
@bryans-go
Copy link
Contributor

tui dtn break
tui also breaking in the latest version 0.31.0

@Tpuljak
Copy link
Member

Tpuljak commented Sep 16, 2024

@bryans-go can you please let us know how to reproduce this?

@bryans-go
Copy link
Contributor

@Tpuljak I used Daytona list on one tab and Daytona create on other tab of the terminal. Which leads to pressure on tui . And the following happened

@idagelic
Copy link
Member

@bryans-go

  1. Run the Daytona server separately
  2. Run daytona list in a new terminal window
  3. Run daytona create on a new tab in the same window

These are all the steps for reproduction? I tried it out and found no issues. Also, the list command does not run indefinitely, it executes immediately so I am curious on how that would make a difference.

Can you please try the reproduction once again and update the steps if necessary? I am also testing on Windows Terminal

@bryans-go
Copy link
Contributor

bryans-go commented Sep 18, 2024

@idagelic So we can conclude that TUI only breaks on custom themes terminal like this terminal app on windows 11. I had a wsl theme which is supplied officially by the windows in order to open wsl instance . also in the start of the issue you said you used Alacritty, along with OMZ . this is a issue with charmbracelet huh or the custom terminals

@abhishek818
Copy link
Contributor

I remember reading few issues on github stating problems with bubbletea tui breaking specifically on alacrity terminal with no apparent fix mentioned. I am guessing it's the problem with the library on certain terminals.

@bryans-go
Copy link
Contributor

@abhishek818 do you mind sharing references or links to those issue here

@idagelic
Copy link
Member

The thing is that I have this issue appear on my setup as well, maybe every hundredth open of daytona create - reproducing it is the real problem since that's the first step to solving. If there are already existing issues on charm libs, I'd like to take a look.

@abhishek818
Copy link
Contributor

abhishek818 commented Sep 18, 2024

I found those issues on github the last time I was working on #725.
Cant find them now upon a brief browsing now, but terminal resize/missing output etc. type of issues with bubbletea on alacritty can be found on their official repo - link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💎 Bounty bug Something isn't working help wanted Extra attention is needed never stale An issue that never goes stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants