Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to angular 18 #62

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Conversation

HosseinSalmanian
Copy link
Contributor

@HosseinSalmanian HosseinSalmanian commented Jun 20, 2024

@davidwalschots I've updated dependencies to angular 18.
I'll be appreciate if you merge this pr.
thanks.

"@angular/common": "^17.0.0",
"@angular/core": "^17.0.0",
"@angular/forms": "^17.0.0",
"@angular/common": "^18.0.3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Could you change these to "^18.0.0" to cover all v18 versions?

"@angular/common": "^17.0.0",
"@angular/core": "^17.0.0",
"@angular/forms": "^17.0.0",
"@angular/common": "^18.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidwalschots
I've rearranged the dependency versions of @Angular/* to ^18.0.0.
Sorry if I made your comment disappear by fixing up the previous commit just to keep history clean.

@davidwalschots davidwalschots merged commit 02dec05 into davidwalschots:main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants